Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1731023003: - Include a random number in the full snapshot filename as some of the tests (Closed)

Created:
4 years, 10 months ago by siva
Modified:
4 years, 10 months ago
Reviewers:
rmacnak, Cutch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Include a random number in the full snapshot filename as some of the tests which have multiple VMOption specifications in them run in parallel with the same snapshot filename and they clobber each other resulting in random crashes - Delete the temporary snapshot generation directory after the test run - Modify map_literal_oom_test.dart to run with 10mb heap limit instead of 7MB as the VM service isolate in the dart_no_snapshot run gets an OOM. R=johnmccutchan@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/993290b59925b58cfd7ffcaa343fee7517f50c14

Patch Set 1 #

Patch Set 2 : self-review-comments #

Patch Set 3 : self-review-comments #

Patch Set 4 : code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -7 lines) Patch
M tests/standalone/map_literal_oom_test.dart View 1 2 1 chunk +15 lines, -1 line 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +8 lines, -6 lines 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 3 4 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
siva
4 years, 10 months ago (2016-02-25 01:36:02 UTC) #2
siva
4 years, 10 months ago (2016-02-25 16:42:20 UTC) #3
Cutch
lgtm
4 years, 10 months ago (2016-02-25 16:47:09 UTC) #4
rmacnak
lgtm
4 years, 10 months ago (2016-02-25 18:24:26 UTC) #5
siva
4 years, 10 months ago (2016-02-25 18:26:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
993290b59925b58cfd7ffcaa343fee7517f50c14 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698