Issue 17310002: Remove unused EME v0.1b MediaKeyError values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17310002: Remove unused EME v0.1b MediaKeyError values. (Closed)

Created:
7 years, 6 months ago by ddorwin

Modified:
7 years, 6 months ago

Reviewers:
xhwang, Ilya Sherman

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
master

Visibility:
Public.

More Reviews

Description

Remove unused EME v0.1b MediaKeyError values. This will avoid them being used before the new errors are defined. BUG=249976 R=isherman@chromium.org, xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207025

Patch Set 1 #

Patch Set 2 : update histograms #

Patch Set 3 : rebase (assert location was moved) #

Patch Set 4 : rebase only #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
M	media/base/media_keys.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	tools/metrics/histograms/histograms.xml	View	1 2 3	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/renderer/media/webmediaplayer_util.cc	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

xhwang

looking good. You also need to update this: https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/histograms/histograms.xml&q=histogram%20xml&sq=package:chromium&type=cs&l=16019

7 years, 6 months ago (2013-06-17 20:18:04 UTC) #2

ddorwin

isherman, please review the histograms change - these values have never been reported and never ...

7 years, 6 months ago (2013-06-17 21:11:11 UTC) #3

ddorwin

7 years, 6 months ago (2013-06-18 17:39:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r207025 (presubmit successful).

Expand Messages | Collapse Messages