Validation of @protected property accesses.

Validation of @protected property accesses.

Follow-on to https://codereview.chromium.org/1723243002/, adding support for field/getter/setters.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/212a058f13f6135cf2ce89d1d3ea58e09731c763

[pquitslund, 2016-02-24 19:37:04]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-02-24 19:54:25]

Add some tests to ensure that we don't generate the hint when we shouldn't (when
applied to a field, getter, or setter)?

Other than that, LGTM.

https://codereview.chromium.org/1730993003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1730993003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:621: if (element != null) {
The 'is' test below should negate the need to the null check.

[pquitslund, 2016-02-24 20:34:43]

Removed null check and added tests.

Thanks!

https://codereview.chromium.org/1730993003/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/1730993003/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:621: if (element != null) {
On 2016/02/24 19:54:25, Brian Wilkerson wrote:
> The 'is' test below should negate the need to the null check.

Nice.  I missed that when I refactored.  Thanks!

[pquitslund, 2016-02-24 20:38:01]

Description was changed from

==========
Validation of @protected property accesses.

Follow-on to https://codereview.chromium.org/1723243002/, adding support for
field/getter/setters.
==========

to

==========
Validation of @protected property accesses.

Follow-on to https://codereview.chromium.org/1723243002/, adding support for
field/getter/setters.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/212a058f13f6135cf2ce89d1d3ea58e09731c763
==========

[pquitslund, 2016-02-24 20:38:09]

Committed patchset #2 (id:20001) manually as
212a058f13f6135cf2ce89d1d3ea58e09731c763 (presubmit successful).