Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(963)

Issue 173098: Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox. (Closed)

Created:
11 years, 4 months ago by Daniel Erat
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox. r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23834

Patch Set 1 #

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Daniel Erat
11 years, 4 months ago (2009-08-19 23:41:46 UTC) #1
Evan Stade
ok
11 years, 4 months ago (2009-08-19 23:44:05 UTC) #2
Dean McNamee
11 years, 4 months ago (2009-08-20 17:59:13 UTC) #3
okay

Powered by Google App Engine
This is Rietveld 408576698