Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1730943003: Rethink DM output (Closed)

Created:
4 years, 10 months ago by mtklein_C
Modified:
4 years, 10 months ago
Reviewers:
reed1, mtklein, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : simplify name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -63 lines) Patch
M dm/DM.cpp View 1 12 chunks +45 lines, -63 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730943003/20001
4 years, 10 months ago (2016-02-24 17:47:09 UTC) #3
mtklein_C
4 years, 10 months ago (2016-02-24 17:59:11 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 18:03:55 UTC) #8
mtklein_C
+Tom
4 years, 10 months ago (2016-02-24 20:10:49 UTC) #10
tomhudson
LGTM. (I wish I was *confident* that we'll never want the old mode, but asking ...
4 years, 10 months ago (2016-02-24 20:13:07 UTC) #11
mtklein
On 2016/02/24 20:13:07, tomhudson wrote: > LGTM. > > (I wish I was *confident* that ...
4 years, 10 months ago (2016-02-24 20:27:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730943003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730943003/20001
4 years, 10 months ago (2016-02-24 20:27:56 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:28:36 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/afae30aeefad374b754b489f3d38519c1faa2247

Powered by Google App Engine
This is Rietveld 408576698