Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1730903007:
Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder (Closed)
|
Created:
4 years, 9 months ago by robertphillips Modified:
4 years, 9 months ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@retract-pipeline Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionMake GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder
Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext.
TBR=bsalomon@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730903007
Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf
Committed: https://skia.googlesource.com/skia/+/4bc31815ba1aa42ea13c5637c6b52262422b7bdb
Patch Set 1 #Patch Set 2 : more #Patch Set 3 : update to ToT #Patch Set 4 : Update to ToT #Messages
Total messages: 26 (16 generated)
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + joshualitt@chromium.org
On 2016/02/25 18:46:40, robertphillips wrote: lgtm
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730903007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730903007/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from joshualitt@google.com Link to the patchset: https://codereview.chromium.org/1730903007/#ps40001 (title: "update to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730903007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730903007/40001
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
robertphillips@google.com changed reviewers: + bsalomon@google.com
Message was sent while issue was closed.
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1737373002/ by ethannicholas@google.com. The reason for reverting is: Got a GL-related crash in nanobench: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Andr... Given we're about to branch and this is the only GL-related change in the blamelist, I'm going to assume this is responsible and revert..
Message was sent while issue was closed.
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf ==========
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730903007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730903007/60001
The CQ bit was unchecked by robertphillips@google.com
The CQ bit was checked by robertphillips@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from joshualitt@google.com Link to the patchset: https://codereview.chromium.org/1730903007/#ps60001 (title: "Update to ToT")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730903007/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730903007/60001
Message was sent while issue was closed.
Description was changed from ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf ========== to ========== Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. TBR=bsalomon@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf Committed: https://skia.googlesource.com/skia/+/4bc31815ba1aa42ea13c5637c6b52262422b7bdb ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/4bc31815ba1aa42ea13c5637c6b52262422b7bdb |
