Issue 173090: NNTP: Limit the dragged item to the viewport boundaries....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173090: NNTP: Limit the dragged item to the viewport boundaries.... (Closed)

Created:
11 years, 4 months ago by arv (Not doing code reviews)

Modified:
9 years, 3 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google), Glen Murphy

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

NNTP: Limit the dragged item to the viewport boundaries. BUG=16361, 15099 TEST=Drag the thumbnails on the new tab page and make sure that the visual representation is never clipped. Also make sure that no new scrollbars show up due to dragging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23775

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -2 lines)			Patch
	M	chrome/browser/resources/new_new_tab.js	View		1 chunk	+17 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Miranda Callahan

lgtm with nitlet On 2009/08/19 22:35:16, arv wrote: >

11 years, 4 months ago (2009-08-19 22:48:47 UTC) #2

Miranda Callahan

11 years, 4 months ago (2009-08-19 22:49:01 UTC) #3

http://codereview.chromium.org/173090/diff/4/1001
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/173090/diff/4/1001#newcode1490
Line 1490: // subtract that when calculation the allowed position.
s/calculation/calculating

Expand Messages | Collapse Messages