Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1730833003: SkPDF/Bench: add bench for SkPDFSharedStream (deflate) (Closed)

Created:
4 years, 10 months ago by hal.canary
Modified:
4 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : 2016-02-24 (Wednesday) 13:48:33 EST #

Total comments: 2

Patch Set 3 : 2016-02-24 (Wednesday) 16:20:08 EST #

Patch Set 4 : 2016-02-24 (Wednesday) 17:03:32 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4854 lines, -22 lines) Patch
M bench/PDFBench.cpp View 1 2 5 chunks +47 lines, -16 lines 0 comments Download
M gyp/bench.gyp View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M gyp/bench.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gyp/visualbench.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
A resources/pdf_command_stream.txt View 1 1 chunk +4802 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
hal.canary
4 years, 10 months ago (2016-02-24 18:14:48 UTC) #4
hal.canary
added an example pdf command stream to resources/
4 years, 10 months ago (2016-02-24 18:48:36 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730833003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730833003/40001
4 years, 10 months ago (2016-02-24 18:49:03 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/598)
4 years, 10 months ago (2016-02-24 18:50:02 UTC) #11
mtklein
lgtm https://codereview.chromium.org/1730833003/diff/1/gyp/bench.gyp File gyp/bench.gyp (right): https://codereview.chromium.org/1730833003/diff/1/gyp/bench.gyp#newcode32 gyp/bench.gyp:32: 'include_dirs': [ '../src/pdf' ], Think this goes with ...
4 years, 10 months ago (2016-02-24 19:59:44 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730833003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730833003/60001
4 years, 10 months ago (2016-02-24 21:20:27 UTC) #14
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_64-Release-Trybot/builds/606)
4 years, 10 months ago (2016-02-24 21:23:08 UTC) #16
hal.canary
https://codereview.chromium.org/1730833003/diff/40001/bench/PDFBench.cpp File bench/PDFBench.cpp (right): https://codereview.chromium.org/1730833003/diff/40001/bench/PDFBench.cpp#newcode143 bench/PDFBench.cpp:143: SkAutoTDelete<SkStreamAsset> fRandomText; On 2016/02/24 at 19:59:44, mtklein wrote: > ...
4 years, 10 months ago (2016-02-24 22:07:16 UTC) #17
hal.canary
On 2016/02/24 at 19:59:44, mtklein wrote: > lgtm > > https://codereview.chromium.org/1730833003/diff/1/gyp/bench.gyp > File gyp/bench.gyp (right): ...
4 years, 10 months ago (2016-02-24 22:07:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730833003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730833003/80001
4 years, 10 months ago (2016-02-24 22:08:11 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 23:17:23 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as
https://skia.googlesource.com/skia/+/1e440510d8c3ee933a5ada6947cbc56f166e3d7b

Powered by Google App Engine
This is Rietveld 408576698