Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1730763002: MIPS: Fix c-linkage. (Closed)

Created:
4 years, 10 months ago by akos.palfi.imgtec
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix c-linkage. Per MIPS O32 ABI the first four arguments must be passed via the a0-a3 registers and they must be on the stack as well. TEST=cctest/test-run-wasm/* BUG= Committed: https://crrev.com/85c735729870be01b3e98ccacda1c37dc0076b31 Cr-Commit-Position: refs/heads/master@{#34260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/compiler/c-linkage.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
akos.palfi.imgtec
PTAL.
4 years, 10 months ago (2016-02-23 21:38:05 UTC) #2
balazs.kilvady
lgtm
4 years, 10 months ago (2016-02-24 14:07:29 UTC) #3
akos.palfi.imgtec
Ben, Could you PTAL? This CL fixes a ton of wasm tests on mips.
4 years, 10 months ago (2016-02-24 15:35:17 UTC) #4
titzer
lgtm
4 years, 10 months ago (2016-02-24 17:30:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730763002/1
4 years, 10 months ago (2016-02-24 17:39:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 18:20:21 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:21:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c735729870be01b3e98ccacda1c37dc0076b31
Cr-Commit-Position: refs/heads/master@{#34260}

Powered by Google App Engine
This is Rietveld 408576698