Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730753002: Simplify CFDE_CSSStyleSelector::SortRulesTo(). (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Simplify CFDE_CSSStyleSelector::SortRulesTo(). Also remove another CFX_ArrayTemplate usage. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a7f70cc1ff7d54b92d9c55326c1439a25116e00c

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -37 lines) Patch
M xfa/src/fdp/src/css/fde_cssstyleselector.h View 4 chunks +3 lines, -3 lines 0 comments Download
M xfa/src/fdp/src/css/fde_cssstyleselector.cpp View 1 2 4 chunks +28 lines, -34 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
4 years, 10 months ago (2016-02-23 21:44:15 UTC) #3
Tom Sepez
lgtm https://codereview.chromium.org/1730753002/diff/20001/xfa/src/fdp/src/css/fde_cssstyleselector.cpp File xfa/src/fdp/src/css/fde_cssstyleselector.cpp (right): https://codereview.chromium.org/1730753002/diff/20001/xfa/src/fdp/src/css/fde_cssstyleselector.cpp#newcode348 xfa/src/fdp/src/css/fde_cssstyleselector.cpp:348: if (!m_MatchedRules.empty()) { Do we still need this ...
4 years, 10 months ago (2016-02-23 23:34:02 UTC) #4
Lei Zhang
https://codereview.chromium.org/1730753002/diff/20001/xfa/src/fdp/src/css/fde_cssstyleselector.cpp File xfa/src/fdp/src/css/fde_cssstyleselector.cpp (right): https://codereview.chromium.org/1730753002/diff/20001/xfa/src/fdp/src/css/fde_cssstyleselector.cpp#newcode348 xfa/src/fdp/src/css/fde_cssstyleselector.cpp:348: if (!m_MatchedRules.empty()) { On 2016/02/23 23:34:02, Tom Sepez wrote: ...
4 years, 10 months ago (2016-02-24 00:06:36 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-24 00:07:00 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
a7f70cc1ff7d54b92d9c55326c1439a25116e00c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698