Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730723002: [fusl] Remove socketcall abstraction (Closed)

Created:
4 years, 10 months ago by kulakowski
Modified:
4 years, 10 months ago
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[fusl] Remove socketcall abstraction i386 was the only architecture which required this indirection. R=phosek@chromium.org, viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ad00c8ee4181b58d6df219cf3c839839221499a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -60 lines) Patch
M fusl/src/internal/syscall.h View 3 chunks +0 lines, -40 lines 0 comments Download
M fusl/src/network/accept.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/accept4.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/bind.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/connect.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/getpeername.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/getsockname.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/getsockopt.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/listen.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/recvfrom.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/recvmsg.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/sendmsg.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/sendto.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/setsockopt.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/shutdown.c View 1 chunk +1 line, -1 line 0 comments Download
M fusl/src/network/socket.c View 1 chunk +3 lines, -3 lines 0 comments Download
M fusl/src/network/socketpair.c View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kulakowski
Depends on the other CL removing i386 headers.
4 years, 10 months ago (2016-02-24 17:46:57 UTC) #1
kulakowski
Trung's out, ptal.
4 years, 10 months ago (2016-02-26 17:30:10 UTC) #4
Petr Hosek
lgtm
4 years, 10 months ago (2016-02-26 18:23:11 UTC) #5
kulakowski
4 years, 10 months ago (2016-02-26 18:36:53 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ad00c8ee4181b58d6df219cf3c839839221499a9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698