Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730713002: Moar _CAPS work, part 3. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Patch Set 3 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -149 lines) Patch
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 12 chunks +15 lines, -15 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_monthcalendarimp.h View 6 chunks +43 lines, -50 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_ffdoc.h View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fftext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fxfa/src/app/xfa_textlayout.h View 1 2 3 chunks +12 lines, -16 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_textlayout.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_object.h View 3 chunks +14 lines, -12 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_script.h View 2 chunks +12 lines, -8 lines 0 comments Download
M xfa/src/fxfa/src/parser/xfa_object_imp.cpp View 1 11 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, part 3.
4 years, 10 months ago (2016-02-23 20:05:35 UTC) #2
Lei Zhang
lgtm There might be some merge conflicts BTW. https://codereview.chromium.org/1730713002/diff/1/xfa/src/fxfa/src/app/xfa_textlayout.h File xfa/src/fxfa/src/app/xfa_textlayout.h (right): https://codereview.chromium.org/1730713002/diff/1/xfa/src/fxfa/src/app/xfa_textlayout.h#newcode230 xfa/src/fxfa/src/app/xfa_textlayout.h:230: XFA_TEXTPIECE() ...
4 years, 10 months ago (2016-02-23 20:42:05 UTC) #3
Tom Sepez
4 years, 10 months ago (2016-02-23 23:34:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
d9aba86443b32b686cf25b5465bbcaad9f04c308 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698