Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: src/frames.h

Issue 1730673002: Revert of Add WasmFrame, backtraces reflect wasm's presence (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/frames.h
diff --git a/src/frames.h b/src/frames.h
index 24f2e876358434009e0211f57ceb27e9d3abe6d2..f33eb167414af18081c82864dde237c3f5a46c2e 100644
--- a/src/frames.h
+++ b/src/frames.h
@@ -96,6 +96,7 @@
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(StackHandler);
};
+
#define STACK_FRAME_TYPE_LIST(V) \
V(ENTRY, EntryFrame) \
@@ -103,7 +104,6 @@
V(EXIT, ExitFrame) \
V(JAVA_SCRIPT, JavaScriptFrame) \
V(OPTIMIZED, OptimizedFrame) \
- V(WASM, WasmFrame) \
V(INTERPRETED, InterpretedFrame) \
V(STUB, StubFrame) \
V(STUB_FAILURE_TRAMPOLINE, StubFailureTrampolineFrame) \
@@ -310,7 +310,6 @@
bool is_exit() const { return type() == EXIT; }
bool is_optimized() const { return type() == OPTIMIZED; }
bool is_interpreted() const { return type() == INTERPRETED; }
- bool is_wasm() const { return type() == WASM; }
bool is_arguments_adaptor() const { return type() == ARGUMENTS_ADAPTOR; }
bool is_internal() const { return type() == INTERNAL; }
bool is_stub_failure_trampoline() const {
@@ -618,7 +617,8 @@
bool is_constructor_;
};
-class JavaScriptFrame : public StandardFrame {
+
+class JavaScriptFrame: public StandardFrame {
public:
Type type() const override { return JAVA_SCRIPT; }
@@ -841,28 +841,6 @@
friend class StackFrameIteratorBase;
};
-class WasmFrame : public StandardFrame {
- public:
- Type type() const override { return WASM; }
-
- // GC support.
- void Iterate(ObjectVisitor* v) const override;
-
- // Printing support.
- void Print(StringStream* accumulator, PrintMode mode,
- int index) const override;
-
- // Determine the code for the frame.
- Code* unchecked_code() const override;
-
- protected:
- inline explicit WasmFrame(StackFrameIteratorBase* iterator);
-
- Address GetCallerStackPointer() const override;
-
- private:
- friend class StackFrameIteratorBase;
-};
class InternalFrame: public StandardFrame {
public:
@@ -996,6 +974,7 @@
DISALLOW_COPY_AND_ASSIGN(StackFrameIterator);
};
+
// Iterator that supports iterating through all JavaScript frames.
class JavaScriptFrameIterator BASE_EMBEDDED {
public:
@@ -1017,6 +996,7 @@
private:
StackFrameIterator iterator_;
};
+
// NOTE: The stack trace frame iterator is an iterator that only
// traverse proper JavaScript frames; that is JavaScript frames that
« no previous file with comments | « no previous file | src/frames.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698