core/src/fxcrt/fx_basic_bstring.cpp - Issue 1730553002: Fixing whitespace lint errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fx_basic_bstring.cpp

Issue 1730553002: Fixing whitespace lint errors. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Review changes Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcrt/fx_basic_bstring.cpp

diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp

index af06f0074b18f1ddf3ff5b42dabd7b5755af1f11..3eaee17720d14314f1b3bdec3094495cdb260e5b 100644

--- a/core/src/fxcrt/fx_basic_bstring.cpp

+++ b/core/src/fxcrt/fx_basic_bstring.cpp

@@ -486,9 +486,8 @@ void CFX_ByteString::FormatV(const FX_CHAR* lpszFormat, va_list argList) {

nMaxLen += 2;

} else if (*lpsz == '*') {

nWidth = va_arg(argList, int);

- } else if (*lpsz == '-' || *lpsz == '+' || *lpsz == '0' || *lpsz == ' ')

- ;

- else {

+ } else if (*lpsz == '-' || *lpsz == '+' || *lpsz == '0' || *lpsz == ' ') {

Lei Zhang 2016/02/24 01:37:01 negate this and break?

dsinclair 2016/02/24 14:51:08 Done.

+ } else {

break;

}