Fixing whitespace lint errors.

Fixing whitespace lint errors.

This CL enables several of the diabled whitelist/* lint checks.

R=thestig@chromium.org, tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/50cce609050e1a40e1d6936e0a3f0614b4483eee

[dsinclair, 2016-02-23 15:48:06]

Patchset #1 (id:1) has been deleted

[dsinclair, 2016-02-23 15:53:58]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-02-23 15:53:59]

PTAL.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
File xfa/src/fdp/src/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:847: while ((++m_pCur < m_pEnd) &&
(*m_pCur != wch) && (*m_pCur > ' ')) {
I added ()'s to this to keep git cl format from doing the mess on the left.

[Tom Sepez, 2016-02-23 17:44:19]

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
File core/src/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
core/src/fxcrt/fx_extension.cpp:335: time_t tmLast = time(NULL), tmCur;
nit: one per line.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
core/src/fxcrt/fx_extension.cpp:336: while ((tmCur = time(NULL)) == tmLast) {
nit: my personal preference is to use "continue" for empty loop bodies, but this
is allowd per our standards, so no need to change if you like it this way.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
File core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c:1: // Copyright 2014
PDFium Authors. All rights reserved.
Maybe we rename this to be a .cpp file?

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c:10: 0x0, 0x4, 0x2, 0x0,
0x1, 0x1, 0x1, 0x11,
git cl format did this?  Strange, wider than 80.  One way of thwarting its
obnoxious array formatting is to start with a comment 
const unsigned char g_FoxitDingbatsFontData[29513] = {
  // Dingbats font data.
  0x1, ...

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
File core/src/fxge/fontdata/chromefontdata/FoxitFixed.c (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitFixed.c:1: // Copyright 2014 PDFium
Authors. All rights reserved.
ditto, ditto

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/skia/fx_s...
File core/src/fxge/skia/fx_skia_blitter_new.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/skia/fx_s...
core/src/fxge/skia/fx_skia_blitter_new.cpp:7: // #define _SKIA_SUPPORT_
Nit: remove this line.

https://codereview.chromium.org/1730553002/diff/20001/fpdfsdk/include/fsdk_ba...
File fpdfsdk/include/fsdk_baseform.h (right):

https://codereview.chromium.org/1730553002/diff/20001/fpdfsdk/include/fsdk_ba...
fpdfsdk/include/fsdk_baseform.h:213: #ifndef PDF_ENABLE_XFA
This looks like a merge failure.  Can we just remove the ifdef and make it
private always?

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fwl/core/fw...
File xfa/include/fwl/core/fwl_note.h (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fwl/core/fw...
xfa/include/fwl/core/fwl_note.h:189: ;  // NOLINT
what's the issue with these?

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fxjse/fxjse.h
File xfa/include/fxjse/fxjse.h (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fxjse/fxjse...
xfa/include/fxjse/fxjse.h:21: // NOLINTNEXTLINE
what's the issue here?

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
File xfa/src/fdp/src/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:847: while ((++m_pCur < m_pEnd) &&
(*m_pCur != wch) && (*m_pCur > ' ')) {
On 2016/02/23 15:53:59, dsinclair wrote:
> I added ()'s to this to keep git cl format from doing the mess on the left.
Really? That's bad.  I've not seen it do that before. You should ping the
clang-format guys ...

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/app/xf...
File xfa/src/fxfa/src/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/app/xf...
xfa/src/fxfa/src/app/xfa_textlayout.cpp:1464: while (iTabCount-- > 0) {
nit: you can lose the inner {} now that the outer if has {}.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/parser...
File xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp:310: 
nit: no blank line here, maybe after 311?

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxjse/src/conte...
File xfa/src/fxjse/src/context.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxjse/src/conte...
xfa/src/fxjse/src/context.cpp:43: "(function (global, list) { 'use strict'; var
objname; for (objname in list) { var globalobj = global[objname];\n\
can we make this less of a mess? Use concatenation of adjacent literals,
one per line?

[dsinclair, 2016-02-23 19:14:02]

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
File core/src/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
core/src/fxcrt/fx_extension.cpp:335: time_t tmLast = time(NULL), tmCur;
On 2016/02/23 17:44:18, Tom Sepez wrote:
> nit: one per line.

Done.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxcrt/fx_exten...
core/src/fxcrt/fx_extension.cpp:336: while ((tmCur = time(NULL)) == tmLast) {
On 2016/02/23 17:44:18, Tom Sepez wrote:
> nit: my personal preference is to use "continue" for empty loop bodies, but
this
> is allowd per our standards, so no need to change if you like it this way.

Done.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
File core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c:1: // Copyright 2014
PDFium Authors. All rights reserved.
On 2016/02/23 17:44:19, Tom Sepez wrote:
> Maybe we rename this to be a .cpp file?

Will do in a separate CL.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c:10: 0x0, 0x4, 0x2, 0x0,
0x1, 0x1, 0x1, 0x11,
On 2016/02/23 17:44:19, Tom Sepez wrote:
> git cl format did this?  Strange, wider than 80.  One way of thwarting its
> obnoxious array formatting is to start with a comment 
> const unsigned char g_FoxitDingbatsFontData[29513] = {
>   // Dingbats font data.
>   0x1, ...

Done.

git cl format seems to ignore these files unless you request them specifically
to be formatted.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
File core/src/fxge/fontdata/chromefontdata/FoxitFixed.c (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/fontdata/...
core/src/fxge/fontdata/chromefontdata/FoxitFixed.c:1: // Copyright 2014 PDFium
Authors. All rights reserved.
On 2016/02/23 17:44:19, Tom Sepez wrote:
> ditto, ditto

Acknowledged.

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/skia/fx_s...
File core/src/fxge/skia/fx_skia_blitter_new.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/core/src/fxge/skia/fx_s...
core/src/fxge/skia/fx_skia_blitter_new.cpp:7: // #define _SKIA_SUPPORT_
On 2016/02/23 17:44:19, Tom Sepez wrote:
> Nit: remove this line.

Done.

https://codereview.chromium.org/1730553002/diff/20001/fpdfsdk/include/fsdk_ba...
File fpdfsdk/include/fsdk_baseform.h (right):

https://codereview.chromium.org/1730553002/diff/20001/fpdfsdk/include/fsdk_ba...
fpdfsdk/include/fsdk_baseform.h:213: #ifndef PDF_ENABLE_XFA
On 2016/02/23 17:44:19, Tom Sepez wrote:
> This looks like a merge failure.  Can we just remove the ifdef and make it
> private always?

Done.

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fwl/core/fw...
File xfa/include/fwl/core/fwl_note.h (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fwl/core/fw...
xfa/include/fwl/core/fwl_note.h:189: ;  // NOLINT
On 2016/02/23 17:44:19, Tom Sepez wrote:
> what's the issue with these?

Semicolon isn't allowed on a line by itself. git cl format wants it on a line by
itself.

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fxjse/fxjse.h
File xfa/include/fxjse/fxjse.h (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/include/fxjse/fxjse...
xfa/include/fxjse/fxjse.h:21: // NOLINTNEXTLINE
On 2016/02/23 17:44:19, Tom Sepez wrote:
> what's the issue here?

No space before {. git cl format wants there to be no space.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
File xfa/src/fdp/src/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fdp/src/css/fde...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:847: while ((++m_pCur < m_pEnd) &&
(*m_pCur != wch) && (*m_pCur > ' ')) {
On 2016/02/23 17:44:19, Tom Sepez wrote:
> On 2016/02/23 15:53:59, dsinclair wrote:
> > I added ()'s to this to keep git cl format from doing the mess on the left.
> Really? That's bad.  I've not seen it do that before. You should ping the
> clang-format guys ...

Acknowledged.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/app/xf...
File xfa/src/fxfa/src/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/app/xf...
xfa/src/fxfa/src/app/xfa_textlayout.cpp:1464: while (iTabCount-- > 0) {
On 2016/02/23 17:44:19, Tom Sepez wrote:
> nit: you can lose the inner {} now that the outer if has {}.

Done.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/parser...
File xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxfa/src/parser...
xfa/src/fxfa/src/parser/xfa_script_nodehelper.cpp:310: 
On 2016/02/23 17:44:19, Tom Sepez wrote:
> nit: no blank line here, maybe after 311?

Done.

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxjse/src/conte...
File xfa/src/fxjse/src/context.cpp (right):

https://codereview.chromium.org/1730553002/diff/20001/xfa/src/fxjse/src/conte...
xfa/src/fxjse/src/context.cpp:43: "(function (global, list) { 'use strict'; var
objname; for (objname in list) { var globalobj = global[objname];\n\
On 2016/02/23 17:44:19, Tom Sepez wrote:
> can we make this less of a mess? Use concatenation of adjacent literals,
> one per line?

Yes, but it's still horrible.

[Tom Sepez, 2016-02-24 00:30:20]

lgtm

[Lei Zhang, 2016-02-24 01:37:01]

lgtm

https://codereview.chromium.org/1730553002/diff/40001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:667: if (pFont->GetFontType()
== PDFFONT_TYPE3) {
if (pFont->GetFontType() != PDFFONT_TYPE3) {
  if (stroke_argb == 0) {
    ...
  } else {
    ...
  }
}

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxcrt/fx_basic...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxcrt/fx_basic...
core/src/fxcrt/fx_basic_bstring.cpp:489: } else if (*lpsz == '-' || *lpsz == '+'
|| *lpsz == '0' || *lpsz == ' ') {
negate this and break?

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxge/freetype/...
File core/src/fxge/freetype/fx_freetype.c (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxge/freetype/...
core/src/fxge/freetype/fx_freetype.c:34: return 1;
wonky indentation

surprised this file didn't get reformatted with 2 space indentations.

https://codereview.chromium.org/1730553002/diff/40001/xfa/src/fxfa/src/app/xf...
File xfa/src/fxfa/src/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/xfa/src/fxfa/src/app/xf...
xfa/src/fxfa/src/app/xfa_textlayout.cpp:1487: } else if (wsText.GetLength() ==
0) {
} else if (wsText.GetLength() != 0) {
  m_pLoader->m_dwFlags &= ~XFA_LOADERCNTXTFLG_FILTERSPACE;
}

[dsinclair, 2016-02-24 14:51:08]

https://codereview.chromium.org/1730553002/diff/40001/core/src/fpdfapi/fpdf_r...
File core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fpdfapi/fpdf_r...
core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp:667: if (pFont->GetFontType()
== PDFFONT_TYPE3) {
On 2016/02/24 01:37:01, Lei Zhang wrote:
> if (pFont->GetFontType() != PDFFONT_TYPE3) {
>   if (stroke_argb == 0) {
>     ...
>   } else {
>     ...
>   }
> }

Done.

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxcrt/fx_basic...
File core/src/fxcrt/fx_basic_bstring.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxcrt/fx_basic...
core/src/fxcrt/fx_basic_bstring.cpp:489: } else if (*lpsz == '-' || *lpsz == '+'
|| *lpsz == '0' || *lpsz == ' ') {
On 2016/02/24 01:37:01, Lei Zhang wrote:
> negate this and break?

Done.

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxge/freetype/...
File core/src/fxge/freetype/fx_freetype.c (right):

https://codereview.chromium.org/1730553002/diff/40001/core/src/fxge/freetype/...
core/src/fxge/freetype/fx_freetype.c:34: return 1;
On 2016/02/24 01:37:01, Lei Zhang wrote:
> wonky indentation
> 
> surprised this file didn't get reformatted with 2 space indentations.

Done. Could it be because it's .c?

https://codereview.chromium.org/1730553002/diff/40001/xfa/src/fxfa/src/app/xf...
File xfa/src/fxfa/src/app/xfa_textlayout.cpp (right):

https://codereview.chromium.org/1730553002/diff/40001/xfa/src/fxfa/src/app/xf...
xfa/src/fxfa/src/app/xfa_textlayout.cpp:1487: } else if (wsText.GetLength() ==
0) {
On 2016/02/24 01:37:01, Lei Zhang wrote:
> } else if (wsText.GetLength() != 0) {
>   m_pLoader->m_dwFlags &= ~XFA_LOADERCNTXTFLG_FILTERSPACE;
> }

Done.

[dsinclair, 2016-02-24 14:51:22]

Description was changed from

==========
Fixing whitespace lint errors.

This CL enables several of the diabled whitelist/* lint checks.
==========

to

==========
Fixing whitespace lint errors.

This CL enables several of the diabled whitelist/* lint checks.

R=thestig@chromium.org, tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/50cce609050e1a40e1d6936e0a3f0614b448...
==========

[dsinclair, 2016-02-24 14:51:24]

Committed patchset #4 (id:60001) manually as
50cce609050e1a40e1d6936e0a3f0614b4483eee (presubmit successful).