Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Issue 1730523002: Clean up variable usage on LayoutSVGRoot::positionForPoint function (Closed)

Created:
4 years, 10 months ago by hyunjunekim2
Modified:
4 years, 10 months ago
Reviewers:
pdr., fs
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up variable usage on LayoutSVGRoot::positionForPoint function There is same variable closer and change to it. Because increase readability. Committed: https://crrev.com/6b0c05f6d9563919b423d9c7e168d2244684f870 Cr-Commit-Position: refs/heads/master@{#377270}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
hyunjunekim2
Could you check this patch? Thank you.
4 years, 10 months ago (2016-02-23 15:43:21 UTC) #6
fs
lgtm
4 years, 10 months ago (2016-02-23 15:57:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730523002/1
4 years, 10 months ago (2016-02-24 10:15:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 12:07:53 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 12:09:12 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6b0c05f6d9563919b423d9c7e168d2244684f870
Cr-Commit-Position: refs/heads/master@{#377270}

Powered by Google App Engine
This is Rietveld 408576698