third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

index 559d6d6fda0ea05fe58263f49586c508a4c86b95..8ccae38a9f23b23ddf6bcc5350c502a821d8991f 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.h

@@ -15,7 +15,7 @@ class V8RuntimeAgent;

typedef String ErrorString;

-using protocol::OptionalValue;

+using protocol::Maybe;

class V8HeapProfilerAgentImpl : public V8HeapProfilerAgent {

WTF_MAKE_NONCOPYABLE(V8HeapProfilerAgentImpl);

@@ -31,14 +31,14 @@ public:

void collectGarbage(ErrorString*) override;

void enable(ErrorString*) override;

- void startTrackingHeapObjects(ErrorString*, const OptionalValue<bool>& trackAllocations) override;

- void stopTrackingHeapObjects(ErrorString*, const OptionalValue<bool>& reportProgress) override;

+ void startTrackingHeapObjects(ErrorString*, const Maybe<bool>& trackAllocations) override;

+ void stopTrackingHeapObjects(ErrorString*, const Maybe<bool>& reportProgress) override;

void disable(ErrorString*) override;

- void takeHeapSnapshot(ErrorString*, const OptionalValue<bool>& reportProgress) override;

+ void takeHeapSnapshot(ErrorString*, const Maybe<bool>& reportProgress) override;

- void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const OptionalValue<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

+ void getObjectByHeapObjectId(ErrorString*, const String& heapSnapshotObjectId, const Maybe<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

void addInspectedHeapObject(ErrorString*, const String& inspectedHeapObjectId) override;

void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;