third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template ('k') | third_party/WebKit/Source/platform/inspector_protocol/Frontend_h.template » ('j') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

index f68e040dc0e7996274e5b413f8b3d6ac28f0d7e5..c6d4bcb062e082ce0ac5335680e50f44f0ec1d72 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Frontend_cpp.template

@@ -26,7 +26,7 @@ Frontend::Frontend(FrontendChannel* frontendChannel)

void Frontend::{{domain.domain}}::{{event.name}}(

{%- for parameter in event.parameters %}

{% if "optional" in parameter -%}

- {{resolve_type(parameter).optional_pass_type}}

+ const Maybe<{{resolve_type(parameter).raw_type}}>&

{%- else -%}

{%- endif %} {{parameter.name}}{%- if not loop.last -%}, {% endif -%}

@@ -37,9 +37,8 @@ void Frontend::{{domain.domain}}::{{event.name}}(

RefPtr<JSONObject> paramsObject = JSONObject::create();

{% for parameter in event.parameters %}

{% if "optional" in parameter %}

- {{resolve_type(parameter).optional_type}} opt_{{parameter.name}} = {{parameter.name}};

- if (hasValue(opt_{{parameter.name}}))

- paramsObject->setValue("{{parameter.name}}", toValue({{resolve_type(parameter).from_optional_out % ("opt_" + parameter.name)}}));

+ if ({{parameter.name}}.isJust())

+ paramsObject->setValue("{{parameter.name}}", toValue({{parameter.name}}));

{% else %}

paramsObject->setValue("{{parameter.name}}", toValue({{parameter.name}}));

{% endif %}