third_party/WebKit/Source/core/inspector/InspectorInputAgent.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInputAgent.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInputAgent.cpp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorInputAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorInputAgent.h b/third_party/WebKit/Source/core/inspector/InspectorInputAgent.h

index 7f1123ab11395000e0f8ba2f57a15478813cef3c..bd001a23016d32e0ca1b6fe927ff6c82cd651efb 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorInputAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorInputAgent.h

@@ -56,7 +56,7 @@ public:

DECLARE_VIRTUAL_TRACE();

// Methods called from the frontend for simulating input.

- void dispatchTouchEvent(ErrorString*, const String& type, PassOwnPtr<protocol::Array<protocol::Input::TouchPoint>> touchPoints, const OptionalValue<int>& modifiers, const OptionalValue<double>& timestamp) override;

+ void dispatchTouchEvent(ErrorString*, const String& type, PassOwnPtr<protocol::Array<protocol::Input::TouchPoint>> touchPoints, const Maybe<int>& modifiers, const Maybe<double>& timestamp) override;

private:

explicit InspectorInputAgent(InspectedFrames*);