third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

index 3a3a0424b354f37c6dce3451db2e43c092da3866..6b2b6225a15ed2025f516741eda400291d6e0dbd 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

@@ -64,11 +64,11 @@ public:

void enable(ErrorString*) override;

void disable(ErrorString*) override;

- void startTrackingHeapObjects(ErrorString*, const OptionalValue<bool>& trackAllocations) override;

- void stopTrackingHeapObjects(ErrorString*, const OptionalValue<bool>& reportProgress) override;

- void takeHeapSnapshot(ErrorString*, const OptionalValue<bool>& reportProgress) override;

+ void startTrackingHeapObjects(ErrorString*, const Maybe<bool>& trackAllocations) override;

+ void stopTrackingHeapObjects(ErrorString*, const Maybe<bool>& reportProgress) override;

+ void takeHeapSnapshot(ErrorString*, const Maybe<bool>& reportProgress) override;

void collectGarbage(ErrorString*) override;

- void getObjectByHeapObjectId(ErrorString*, const String& objectId, const OptionalValue<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

+ void getObjectByHeapObjectId(ErrorString*, const String& objectId, const Maybe<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

void addInspectedHeapObject(ErrorString*, const String& heapObjectId) override;

void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;

void startSampling(ErrorString*) override;