third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp » ('j') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

index 12d78eae1ac376e5cc6b9f5f6c4fce1c54c1c10f..5ce5f84745187f63f6065c4c4a3f06edcb223aa5 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h

@@ -68,8 +68,8 @@ public:

// DOMDebugger API for InspectorFrontend

void setDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;

void removeDOMBreakpoint(ErrorString*, int nodeId, const String& type) override;

- void setEventListenerBreakpoint(ErrorString*, const String& eventName, const OptionalValue<String>& targetName) override;

- void removeEventListenerBreakpoint(ErrorString*, const String& eventName, const OptionalValue<String>& targetName) override;

+ void setEventListenerBreakpoint(ErrorString*, const String& eventName, const Maybe<String>& targetName) override;

+ void removeEventListenerBreakpoint(ErrorString*, const String& eventName, const Maybe<String>& targetName) override;

void setInstrumentationBreakpoint(ErrorString*, const String& eventName) override;

void removeInstrumentationBreakpoint(ErrorString*, const String& eventName) override;

void setXHRBreakpoint(ErrorString*, const String& url) override;