third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h » ('j') | third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

index a42bac72918792039cf02e9ed0dc6c88344070fb..deb96ad68288beecd16ce6499f97b1e0a80027fd 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h

@@ -48,7 +48,7 @@ class Frontend;

class InstrumentingAgents;

class LocalFrame;

-using protocol::OptionalValue;

+using protocol::Maybe;

class CORE_EXPORT InspectorAgent : public NoBaseWillBeGarbageCollectedFinalized<InspectorAgent> {

USING_FAST_MALLOC_WILL_BE_REMOVED(InspectorAgent);