third_party/WebKit/Source/web/InspectorEmulationAgent.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/InspectorEmulationAgent.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more exports Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp ('k') | third_party/WebKit/Source/web/InspectorEmulationAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/InspectorEmulationAgent.h

diff --git a/third_party/WebKit/Source/web/InspectorEmulationAgent.h b/third_party/WebKit/Source/web/InspectorEmulationAgent.h

index 36e2ce69f67807be13789ae2d6f0a46a98f9ad6c..540cdf30f9d17388153354e4d7da9af201ad0ce1 100644

--- a/third_party/WebKit/Source/web/InspectorEmulationAgent.h

+++ b/third_party/WebKit/Source/web/InspectorEmulationAgent.h

@@ -31,7 +31,7 @@ public:

void resetPageScaleFactor(ErrorString*) override;

void setPageScaleFactor(ErrorString*, double in_pageScaleFactor) override;

void setScriptExecutionDisabled(ErrorString*, bool in_value) override;

- void setTouchEmulationEnabled(ErrorString*, bool in_enabled, const protocol::OptionalValue<String>& in_configuration) override;

+ void setTouchEmulationEnabled(ErrorString*, bool in_enabled, const protocol::Maybe<String>& in_configuration) override;

void setEmulatedMedia(ErrorString*, const String& in_media) override;

void setCPUThrottlingRate(ErrorString*, double in_rate) override;