third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more exports Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('K') | « third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.cpp ('k') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h » ('j') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

diff --git a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

index 1d189ab29f30e37dc282f4ba7d0fea64bd5c98bc..966fced466f839e1af4d5900fa59f0e24184b31e 100644

--- a/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

+++ b/third_party/WebKit/Source/modules/accessibility/InspectorTypeBuilderHelper.cpp

@@ -101,7 +101,7 @@ PassOwnPtr<AXRelatedNode> relatedNodeForAXObject(const AXObject* axObject, Strin

return relatedNode.release();

Element* element = toElement(node);

- const AtomicString& idref = element->getIdAttribute();

+ String idref = element->getIdAttribute();

if (!idref.isEmpty())

relatedNode->setIdref(idref);

@@ -188,7 +188,7 @@ PassOwnPtr<AXValueSource> createValueSource(NameSource& nameSource)

if (nameSource.attribute == aria_labelledbyAttr || nameSource.attribute == aria_labeledbyAttr) {

OwnPtr<AXValue> attributeValue = createRelatedNodeListValue(nameSource.relatedObjects, AXValueTypeEnum::IdrefList);

if (!nameSource.attributeValue.isNull())

- attributeValue->setValue(JSONString::create(nameSource.attributeValue.string()));

+ attributeValue->setValue(JSONString::create(nameSource.attributeValue.string()).get());

valueSource->setAttributeValue(attributeValue.release());

} else if (nameSource.attribute == QualifiedName::null()) {

valueSource->setNativeSourceValue(createRelatedNodeListValue(nameSource.relatedObjects, AXValueTypeEnum::NodeList));