third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more exports Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h ('k') | third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h » ('j') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

index 2913cc83a00757dc406f1fbfae1d87c384ad8727..31ab3dc3c8351b92cd36dc70d034678ef858e832 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

@@ -44,15 +44,15 @@ void InspectorTracingAgent::restore()

emitMetadataEvents();

}

void InspectorTracingAgent::start(ErrorString*,

- const OptionalValue<String>& categories,

- const OptionalValue<String>& options,

- const OptionalValue<double>& bufferUsageReportingInterval,

- const OptionalValue<String>& transferMode,

+ const Maybe<String>& categories,

+ const Maybe<String>& options,

+ const Maybe<double>& bufferUsageReportingInterval,

+ const Maybe<String>& transferMode,

PassRefPtr<StartCallback> callback)

{

ASSERT(sessionId().isEmpty());

m_state->setString(TracingAgentState::sessionId, IdentifiersFactory::createIdentifier());

- m_client->enableTracing(categories.get(String()));

+ m_client->enableTracing(categories.fromMaybe(String()));

emitMetadataEvents();

callback->sendSuccess();

}