third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more exports Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('K') | « third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorInputAgent.h » ('j') | third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

index 2e094fb6646c387bc5f330353319fe8ec9408ece..058d042ee9e4219358b08fc4c7af0ae0c0cd7bf6 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

@@ -120,13 +120,13 @@ void InspectorHeapProfilerAgent::collectGarbage(ErrorString* error)

m_v8HeapProfilerAgent->collectGarbage(error);

}

-void InspectorHeapProfilerAgent::startTrackingHeapObjects(ErrorString* error, const protocol::OptionalValue<bool>& trackAllocations)

+void InspectorHeapProfilerAgent::startTrackingHeapObjects(ErrorString* error, const protocol::Maybe<bool>& trackAllocations)

{

m_v8HeapProfilerAgent->startTrackingHeapObjects(error, trackAllocations);

startUpdateStatsTimer();

}

-void InspectorHeapProfilerAgent::stopTrackingHeapObjects(ErrorString* error, const protocol::OptionalValue<bool>& reportProgress)

+void InspectorHeapProfilerAgent::stopTrackingHeapObjects(ErrorString* error, const protocol::Maybe<bool>& reportProgress)

{

m_v8HeapProfilerAgent->stopTrackingHeapObjects(error, reportProgress);

stopUpdateStatsTimer();

@@ -159,12 +159,12 @@ void InspectorHeapProfilerAgent::disable(ErrorString* error)

stopUpdateStatsTimer();

}

-void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString* errorString, const protocol::OptionalValue<bool>& reportProgress)

+void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString* errorString, const protocol::Maybe<bool>& reportProgress)

{

m_v8HeapProfilerAgent->takeHeapSnapshot(errorString, reportProgress);

}

-void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, const String& heapSnapshotObjectId, const protocol::OptionalValue<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result)

+void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, const String& heapSnapshotObjectId, const protocol::Maybe<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result)

{

bool ok;

unsigned id = heapSnapshotObjectId.toUInt(&ok);