third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator.

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 1730383003: DevTools: consistently use Maybe for optional values in the protocol generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2010, Google Inc. All rights reserved.	2 * Copyright (c) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 24 matching lines...) Expand all Loading...
35 #include "platform/v8_inspector/V8DebuggerScript.h"	35 #include "platform/v8_inspector/V8DebuggerScript.h"

36 #include "platform/v8_inspector/public/V8Debugger.h"	36 #include "platform/v8_inspector/public/V8Debugger.h"

37 #include "wtf/Forward.h"	37 #include "wtf/Forward.h"

38 #include "wtf/PassOwnPtr.h"	38 #include "wtf/PassOwnPtr.h"

39	39

40 #include <v8-debug.h>	40 #include <v8-debug.h>

41 #include <v8.h>	41 #include <v8.h>

42	42

43 namespace blink {	43 namespace blink {

44	44

45 using protocol::OptionalValue;	45 using protocol::Maybe;

46	46

47 class JavaScriptCallFrame;	47 class JavaScriptCallFrame;

48 struct ScriptBreakpoint;	48 struct ScriptBreakpoint;

49 class V8DebuggerAgentImpl;	49 class V8DebuggerAgentImpl;

50	50

51 class V8DebuggerImpl : public V8Debugger {	51 class V8DebuggerImpl : public V8Debugger {

52 WTF_MAKE_NONCOPYABLE(V8DebuggerImpl);	52 WTF_MAKE_NONCOPYABLE(V8DebuggerImpl);

53 public:	53 public:

54 V8DebuggerImpl(v8::Isolate, V8DebuggerClient);	54 V8DebuggerImpl(v8::Isolate, V8DebuggerClient);

55 ~V8DebuggerImpl() override;	55 ~V8DebuggerImpl() override;

(...skipping 17 matching lines...) Expand all Loading...
73 void setPauseOnNextStatement(bool);	73 void setPauseOnNextStatement(bool);

74 bool pausingOnNextStatement();	74 bool pausingOnNextStatement();

75 bool canBreakProgram();	75 bool canBreakProgram();

76 void breakProgram();	76 void breakProgram();

77 void continueProgram();	77 void continueProgram();

78 void stepIntoStatement();	78 void stepIntoStatement();

79 void stepOverStatement();	79 void stepOverStatement();

80 void stepOutOfFunction();	80 void stepOutOfFunction();

81 void clearStepping();	81 void clearStepping();

82	82

83 bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, OwnPtr<protocol::Debugger::SetScriptSourceError>, v8::G lobal<v8::Object> newCallFrames, OptionalValue<bool>* stackChanged);	83 bool setScriptSource(const String& sourceID, const String& newContent, bool preview, String* error, Maybe<protocol::Debugger::SetScriptSourceError>, v8::Gl obal<v8::Object> newCallFrames, Maybe<bool>* stackChanged);

84 v8::Local<v8::Object> currentCallFrames();	84 v8::Local<v8::Object> currentCallFrames();

85 v8::Local<v8::Object> currentCallFramesForAsyncStack();	85 v8::Local<v8::Object> currentCallFramesForAsyncStack();

86 PassRefPtr<JavaScriptCallFrame> callFrameNoScopes(int index);	86 PassRefPtr<JavaScriptCallFrame> callFrameNoScopes(int index);

87 int frameCount();	87 int frameCount();

88	88

89 bool isPaused();	89 bool isPaused();

90 v8::Local<v8::Context> pausedContext() { return m_pausedContext; }	90 v8::Local<v8::Context> pausedContext() { return m_pausedContext; }

91	91

92 v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>);	92 v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>);

93 v8::Local<v8::Value> generatorObjectDetails(v8::Local<v8::Object>&);	93 v8::Local<v8::Value> generatorObjectDetails(v8::Local<v8::Object>&);

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
150 v8::Local<v8::Object> m_executionState;	150 v8::Local<v8::Object> m_executionState;

151 v8::Local<v8::Context> m_pausedContext;	151 v8::Local<v8::Context> m_pausedContext;

152 bool m_runningNestedMessageLoop;	152 bool m_runningNestedMessageLoop;

153 v8::Global<v8::Context> m_regexContext;	153 v8::Global<v8::Context> m_regexContext;

154 };	154 };

155	155

156 } // namespace blink	156 } // namespace blink

157	157

158	158

159 #endif // V8DebuggerImpl_h	159 #endif // V8DebuggerImpl_h

OLD	NEW