Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730353002: WebRTC: Use custom mb_config_path for standalone bots. (Closed)

Created:
4 years, 10 months ago by kjellander_chromium
Modified:
4 years, 10 months ago
Reviewers:
smut
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

WebRTC: Use custom mb_config_path for standalone bots. This combined with https://codereview.webrtc.org/1735593002 should make it possible for us to switch all the iOS bots over to MB. Initially only the iOS GN bots will use MB. BUG=589510 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -46 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 2 chunks +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/ios.py View 2 chunks +31 lines, -1 line 0 comments Download
A + scripts/slave/recipes/webrtc/ios.expected/gn_build.json View 3 chunks +26 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730353002/1
4 years, 10 months ago (2016-02-24 18:17:05 UTC) #2
kjellander_chromium
4 years, 10 months ago (2016-02-24 18:19:03 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 18:20:06 UTC) #6
smut
lgtm
4 years, 10 months ago (2016-02-25 00:57:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730353002/1
4 years, 10 months ago (2016-02-25 00:58:12 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 01:01:55 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298950

Powered by Google App Engine
This is Rietveld 408576698