Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(45)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/uitest/roundtrip_api_call/test.html
Issue
173034
:
Validation of extension api callback and event parameters in DEBUG (Closed)
Patch Set: build docs
Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/extension_uitest.cc
chrome/common/common_resources.grd
chrome/common/extensions/api/extension_api.json
chrome/common/extensions/docs/bookmarks.html
chrome/common/extensions/docs/tabs.html
chrome/common/extensions/docs/windows.html
chrome/renderer/extensions/bindings_utils.h
chrome/renderer/extensions/bindings_utils.cc
chrome/renderer/extensions/event_bindings.h
chrome/renderer/extensions/event_bindings.cc
chrome/renderer/extensions/extension_api_client_unittest.cc
chrome/renderer/extensions/extension_process_bindings.cc
chrome/renderer/renderer_resources.grd
chrome/renderer/resources/event_bindings.js
chrome/renderer/resources/extension_process_bindings.js
chrome/test/data/extensions/samples/tabs/manifest.json
chrome/test/data/extensions/uitest/roundtrip_api_call/test.html
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/test/data/extensions/samples/tabs/manifest.json
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 HOWDIE!!!
1 HOWDIE!!!
2
2
3 <script type="text/javascript">
3 <script type="text/javascript">
4
function
getLastFocusedCallback(num
) {
4
function
getSelectedCallback(tab
) {
5
chrome.tabs.remove(
num
);
5
chrome.tabs.remove(
tab.id
);
6 }
6 }
7
7
8
chrome.
windows.getLastFocused(getLastFocusedCallback
);
8
chrome.
tabs.getSelected(undefined, getSelectedCallback
);
9 </script>
9 </script>
OLD
NEW
« no previous file with comments
|
« chrome/test/data/extensions/samples/tabs/manifest.json
('k') |
no next file »
|
no next file with comments »
Issue 173034: Validation of extension api callback and event parameters in DEBUG (Closed)
Created 11 years, 4 months ago by rafaelw
Modified 9 years, 7 months ago
Reviewers: Matt Perry, Aaron Boodman
Base URL:
Comments: 13
This is Rietveld
408576698
Chromium Code Reviews
Issue 173034:
Validation of extension api callback and event parameters in DEBUG (Closed)
