Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1730313002: Revert of "Implements cachetool to manipulate simple tpyed cache." (Closed)

Created:
4 years, 10 months ago by engedy
Modified:
4 years, 10 months ago
Reviewers:
gabadie, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@i02
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Implements cachetool to manipulate simple tpyed cache." (patchset #1 id:1 of https://codereview.chromium.org/1724833002/ ) Reason for revert: Sorry, again broke compile on https://build.chromium.org/p/chromium/builders/Win. Original issue's description: > Reland of "Implements cachetool to manipulate simple typed cache." > > BUG=582080 > > Original issue's description: > > Revert of Implements cachetool to manipulate simple typed cache. (patchset #4 id:60001 of https://codereview.chromium.org/1710923003/ ) > > > > Reason for revert: > > Broke Win Build, see: https://build.chromium.org/p/chromium/builders/Win/builds/40605. > > > > Original issue's description: > > > Implements cachetool to manipulate simple typed cache. > > > > > > BUG=582080 > > > > > > Committed: https://crrev.com/ebc4faedfca14bab8f932d03e1332b1b72e8430e > > > Cr-Commit-Position: refs/heads/master@{#377007} > > Committed: https://crrev.com/60d7a305d528afb0e5d1b4a3212ff88371aead80 > Cr-Commit-Position: refs/heads/master@{#377312} TBR=gavinp@chromium.org,gabadie@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=582080 Committed: https://crrev.com/5a746baa45ce6ba6daedb40d4592e588542c3331 Cr-Commit-Position: refs/heads/master@{#377317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -237 lines) Patch
M net/net.gyp View 1 chunk +0 lines, -12 lines 0 comments Download
D net/tools/cachetool/cachetool.cc View 1 chunk +0 lines, -225 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
engedy
Created Revert of "Implements cachetool to manipulate simple tpyed cache."
4 years, 10 months ago (2016-02-24 17:51:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730313002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730313002/1
4 years, 10 months ago (2016-02-24 17:52:16 UTC) #2
engedy
FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\4087e065abebdca6dbd0caca2910c6718d2ec67f\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\net\tools\cachetool\cachetool.cachetool.obj.rsp /c ..\..\net\tools\cachetool\cachetool.cc ...
4 years, 10 months ago (2016-02-24 17:52:30 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 17:56:55 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 17:58:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a746baa45ce6ba6daedb40d4592e588542c3331
Cr-Commit-Position: refs/heads/master@{#377317}

Powered by Google App Engine
This is Rietveld 408576698