Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 17303006: Report store buffer overflows to v8 counters. (Closed)

Created:
7 years, 6 months ago by Hannes Payer (out of office)
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Report store buffer overflows to v8 counters. BUG= R=jkummerow@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15234

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/store-buffer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-20 11:37:40 UTC) #1
Michael Starzinger
https://codereview.chromium.org/17303006/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): https://codereview.chromium.org/17303006/diff/1/src/store-buffer.cc#newcode124 src/store-buffer.cc:124: ISOLATE->counters()->store_buffer_overflows()->Increment(); Please do not use the ISOLATE macro here, ...
7 years, 6 months ago (2013-06-20 11:43:48 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/17303006/diff/1/src/store-buffer.cc File src/store-buffer.cc (right): https://codereview.chromium.org/17303006/diff/1/src/store-buffer.cc#newcode124 src/store-buffer.cc:124: ISOLATE->counters()->store_buffer_overflows()->Increment(); On 2013/06/20 11:43:48, Michael Starzinger wrote: > Please ...
7 years, 6 months ago (2013-06-20 11:45:29 UTC) #3
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-06-20 11:46:09 UTC) #4
Michael Starzinger
LGTM.
7 years, 6 months ago (2013-06-20 11:46:53 UTC) #5
Hannes Payer (out of office)
7 years, 6 months ago (2013-06-20 11:48:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r15234 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698