Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1730293002: fix path ops fuzz bug (Closed)

Created:
4 years, 10 months ago by caryclark
Modified:
4 years, 10 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix path ops fuzz bug If one path is empty and the other has extreme values, the intermediate coincident paths cannot be resolved, but triggers an assert that a data structure unexpectedly has zero-length. Tunnel this failure back up to the top and return that the entire path op fails. A future optimization could detect the empty path and avoid this, allowing the op to succeed -- not sure that it's worth the additional logic though. TBR=reed@google.com BUG=535151 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730293002 Committed: https://skia.googlesource.com/skia/+/d78c088b6136590371fddd4cab67bfb4bf692fd3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M src/pathops/SkOpContour.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/pathops/SkOpSegment.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M tests/PathOpsOpTest.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730293002/1
4 years, 10 months ago (2016-02-24 15:51:37 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 16:14:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730293002/1
4 years, 10 months ago (2016-02-24 17:00:37 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 17:03:10 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d78c088b6136590371fddd4cab67bfb4bf692fd3

Powered by Google App Engine
This is Rietveld 408576698