Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1730253002: fixup GLPrograms textblob todo (Closed)

Created:
4 years, 10 months ago by joshua.litt
Modified:
4 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : whoops #

Total comments: 1

Patch Set 3 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/gpu/text/GrAtlasTextContext.cpp View 1 2 2 chunks +10 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
joshualitt
ptal a minor cl
4 years, 10 months ago (2016-02-24 14:05:04 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/1730253002/diff/20001/src/gpu/text/GrAtlasTextContext.cpp File src/gpu/text/GrAtlasTextContext.cpp (right): https://codereview.chromium.org/1730253002/diff/20001/src/gpu/text/GrAtlasTextContext.cpp#newcode410 src/gpu/text/GrAtlasTextContext.cpp:410: Can we remove this comment ?
4 years, 10 months ago (2016-02-24 15:23:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730253002/40001
4 years, 10 months ago (2016-02-24 16:58:05 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 17:23:06 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b8d864902b4c9e893cbdc62eb77c4d49416a2bc1

Powered by Google App Engine
This is Rietveld 408576698