Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Issue 1730243002: [fullcodegen] Factor out EmitNewClosure from architectures. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-full-codegen-named-load
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Factor out EmitNewClosure from architectures. This makes the aforementioned emitting function independent of the target architecture by leveraging existing abstractions. R=mvstanton@chromium.org Committed: https://crrev.com/a0198f2cb6b24cbf1fe30b6f1c54f4db7b894b05 Cr-Commit-Position: refs/heads/master@{#34263}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -197 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -25 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -25 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (4 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-24 14:21:40 UTC) #1
mvstanton
Wow, neat! LGTM.
4 years, 10 months ago (2016-02-24 19:15:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730243002/1
4 years, 10 months ago (2016-02-24 19:17:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 19:19:32 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 19:20:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0198f2cb6b24cbf1fe30b6f1c54f4db7b894b05
Cr-Commit-Position: refs/heads/master@{#34263}

Powered by Google App Engine
This is Rietveld 408576698