Add skeleton for an about:net-internal page....

Add skeleton for an about:net-internal page.

This page contains low-level debug information that is of interest to power users, and bug investigators.

The output can be filtered by using special sub-URLs.
The sub-URLs themselves are listed when visiting about:net-internal, but to give an idea:

  about:net-internal -- everything
  about:net-internal/proxyservice -- all things proxy
  about:net-internal/proxyservice.config -- current settings
  about:net-internal/hostresolver.hostcache -- dns cache
  
BUG=http://crbug.com/14478
R=darin

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25109

[eroman, 2009-08-18 22:47:25]

Here is a preview of how it currently looks:
(obviously still incomplete)

http://www/~ericroman/tmp/general.png
http://www/~ericroman/tmp/specific.png

[eroman, 2009-08-18 23:21:31]

What would be the analog in this case?

Would it be to have like:

  about:net-internal/proxy
  about:net-internal/proxys
  about:net-internal/proxyse
  about:net-internal/proxyser

all be equivalent to

  about:net-internal/proxyservice



(The main reason I want sub-URLs, is so in bug reports I can tell users things
like "copy-paste what you see under view-net-internal:ProxyService")

[darin (slow to review), 2009-08-18 23:45:29]

On Tue, Aug 18, 2009 at 4:21 PM, <eroman@chromium.org> wrote:

> What would be the analog in this case?
>
> Would it be to have like:
>
>  about:net-internal/proxy
>  about:net-internal/proxys
>  about:net-internal/proxyse
>  about:net-internal/proxyser
>
> all be equivalent to
>
>  about:net-internal/proxyservice
>
>
maybe substring matching is not so important.  the main thing i was aiming
for was a similar syntax.  substring matching could be helpful if you wanted
to have subcategories underneath proxyservice (e.g.,
"about:net-internal/proxyserver.v8")

-darin



>
>
> (The main reason I want sub-URLs, is so in bug reports I can tell users
> things like "copy-paste what you see under
> view-net-internal:ProxyService")
>
>
> http://codereview.chromium.org/173024
>

[darin (slow to review), 2009-08-18 23:55:22]

perhaps it would make sense to use a syntax like we have for histograms?
about:histograms/Foo

shows any histogram with a name that contains the substring "Foo"

-darin



On Tue, Aug 18, 2009 at 3:44 PM, <eroman@chromium.org> wrote:

> Reviewers: darin,
>
> Description:
> Add skeleton for an about:net-internal page.
>
> These page contains low-level debug information that is of interest to
> power users, and bug investigators.
>
> Exposes the following magical URLS:
>
>  about:net-internal
>    * Shortcut for "view-net-internal:".
>    *
>  view-net-internal:
>    * Displays all of the internal information.
>
>  view-net-internal:HostResolver
>    * Shows just the HostResolver informaiton.
>      + Host cache entries (expiration, cached address).
>
>  view-net-internal:ProxyService
>    * Shows just the ProxyService information.
>      + The currently loaded configuration.
>      + The profiling information for initialization (LoadLog).
>      + The map of "bad" proxies.
>
>  view-net-internal:URLRequest
>    * Shows information for all of the outstanding URLRequests.
>      + Current status.
>      + Profiling information (LoadLog).
>
> BUG=http://crbug.com/14478
> R=darin
>
> Please review this at http://codereview.chromium.org/173024
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/browser_about_handler.cc
>  M     chrome/common/url_constants.h
>  M     chrome/common/url_constants.cc
>  M     net/net.gyp
>  M     net/proxy/proxy_service.h
>  M     net/url_request/url_request_job_manager.cc
>  A     net/url_request/url_request_view_net_internal_job.h
>  A     net/url_request/url_request_view_net_internal_job.cc
>
>
>

[eroman, 2009-08-19 02:31:38]

> perhaps it would make sense to use a syntax like we have for histograms?
> about:histograms/Foo

Done.

You can now select any subsection in the hiearchy through a URL.

Also, each heading shows what the magic URL for it is:

http://www/~ericroman/tmp/general.png

[eroman, 2009-09-01 18:03:35]

ping

[darin (slow to review), 2009-09-01 20:06:12]

LGTM... except:

http://codereview.chromium.org/173024/diff/23/28
File net/url_request/url_request_view_net_internal_job.cc (right):

http://codereview.chromium.org/173024/diff/23/28#newcode266
Line 266: data->append(path);
perhaps this path should be HTML escaped?

[eroman, 2009-09-01 22:45:31]

http://codereview.chromium.org/173024/diff/23/28
File net/url_request/url_request_view_net_internal_job.cc (right):

http://codereview.chromium.org/173024/diff/23/28#newcode266
Line 266: data->append(path);
On 2009/09/01 20:06:12, darin wrote:
> perhaps this path should be HTML escaped?

Done.

[darin (slow to review), 2009-09-01 22:49:10]

LGTM