Make Mac first run store sentinel in Profile directory.

Make Mac first run store sentinel in Profile directory.

* Added code to migrate from previous defaults-based first run.
* Renamed linux_guid -> posix_guid.
BUG=19260
TEST=Open current official release and go through first run UI, then open a release compiled with this patch.  First run UI should not be displayed again.
TEST=First Run UI should only be displayed once on first run and not anew on each launch.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23686

[Mark Mentovai, 2009-08-18 21:51:46]

LG with some changes.

http://codereview.chromium.org/173020/diff/28/1002
File chrome/browser/first_run.cc (right):

http://codereview.chromium.org/173020/diff/28/1002#newcode61
Line 61: // A troolean, 0 means not yet set, 1 means set to true, 2 set to
false.
Ought to be an enum.

http://codereview.chromium.org/173020/diff/28/1003
File chrome/browser/first_run_mac.mm (right):

http://codereview.chromium.org/173020/diff/28/1003#newcode22
Line 22: // in the near future once most people are upgraded.
Put a TODO on it.  Put specific conditions for removal.  The style guide covers
this.

http://codereview.chromium.org/173020/diff/28/1003#newcode27
Line 27: // returns - is this the first run?
What's this mean?

http://codereview.chromium.org/173020/diff/28/1003#newcode62
Line 62: // returns - true - performed migration, false - no previous first run
Use complete sentences, especially when you're describing what a function is
supposed to do.

http://codereview.chromium.org/173020/diff/28/1003#newcode190
Line 190: #else
I'd just leave the #else out.  You can keep the comment, but it doesn't need an
#else.

http://codereview.chromium.org/173020/diff/28/1004
File chrome/browser/first_run_migration_mac_unittest.mm (right):

http://codereview.chromium.org/173020/diff/28/1004#newcode5
Line 5: #include <Foundation/Foundation.h>
#import this one.

http://codereview.chromium.org/173020/diff/28/1004#newcode14
Line 14: // for details.
I'm surprised you're adding a test for temporary code.

http://codereview.chromium.org/173020/diff/28/1009
File chrome/browser/google_update_settings_posix.cc (right):

http://codereview.chromium.org/173020/diff/28/1009#newcode15
Line 15: std::string posix_guid;
But we don't ever use this on the Mac.

I'd #ifdef it to keep our code/data size down.