Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 173016: Add LowMemoryNotification to the API on Android platform.... (Closed)

Created:
11 years, 4 months ago by Feng Qian
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add LowMemoryNotification to the API on Android platform. Android system provides a unique feature that it sends a notification to the browser in low memory condition, and the browser cleans up cache and frees resources. Forcing a GC in low memory condition can free DOM objects and also can shrink the old spaces.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M include/v8.h View 1 chunk +9 lines, -0 lines 2 comments Download
M src/api.cc View 1 chunk +9 lines, -1 line 1 comment Download
M src/heap.h View 1 chunk +3 lines, -2 lines 1 comment Download
M src/heap.cc View 1 chunk +4 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Mads Ager (chromium)
LGTM once these comments have been addressed. http://codereview.chromium.org/173016/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/173016/diff/1/2#newcode2246 Line 2246: #if ...
11 years, 4 months ago (2009-08-19 17:24:23 UTC) #1
Feng Qian
11 years, 4 months ago (2009-08-19 17:30:30 UTC) #2
Feng Qian
Replaced by http://codereview.chromium.org/173102 which add a global flag to MarkCompactCollector for forcing compaction. http://codereview.chromium.org/173016/diff/1/2 File ...
11 years, 4 months ago (2009-08-20 00:06:08 UTC) #3
Kasper Lund
http://codereview.chromium.org/173016/diff/1/3 File src/api.cc (right): http://codereview.chromium.org/173016/diff/1/3#newcode2611 Line 2611: #endif Would it make sense to always do ...
11 years, 4 months ago (2009-08-20 06:54:56 UTC) #4
Feng Qian
11 years, 4 months ago (2009-08-20 16:01:18 UTC) #5

          

Powered by Google App Engine
This is Rietveld 408576698