Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1730143003: md5check'ify lint.py (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

md5check'ify lint.py When locally building chrome_public_apk_incremental and making a non-public change to a content_java file, this brings ninja time: 24s -> 7s BUG=None Committed: https://crrev.com/b84f70aeb94075c8f6ec85a8211b231a9125ba41 Cr-Commit-Position: refs/heads/master@{#377614}

Patch Set 1 #

Patch Set 2 : Only lint changed files. Brings time down to 7s #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -23 lines) Patch
M build/android/gyp/lint.py View 1 7 chunks +38 lines, -23 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
agrieve
On 2016/02/24 19:24:28, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🔝
4 years, 10 months ago (2016-02-24 19:24:47 UTC) #3
jbudorick
lgtm
4 years, 10 months ago (2016-02-25 16:09:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1730143003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1730143003/20001
4 years, 10 months ago (2016-02-25 16:33:13 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 18:07:42 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b84f70aeb94075c8f6ec85a8211b231a9125ba41 Cr-Commit-Position: refs/heads/master@{#377614}
4 years, 10 months ago (2016-02-25 18:09:50 UTC) #11
agrieve
4 years, 10 months ago (2016-02-25 19:48:22 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1739903002/ by agrieve@chromium.org.

The reason for reverting is: Breaking bots..

Powered by Google App Engine
This is Rietveld 408576698