Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/_internal/lib/js_string.dart

Issue 17301008: Remove =List in JS, use JSExtendableArray instead. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/lib/js_rti.dart ('K') | « sdk/lib/_internal/lib/js_rti.dart ('k') | sdk/lib/_internal/lib/json_patch.dart » ('j') | sdk/lib/html/html_common/conversions.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/lib/js_string.dart
===================================================================
--- sdk/lib/_internal/lib/js_string.dart (revision 24212)
+++ sdk/lib/_internal/lib/js_string.dart (working copy)
@@ -76,10 +76,10 @@
List<String> split(Pattern pattern) {
checkNull(pattern);
if (pattern is String) {
- return JS('=List', r'#.split(#)', this, pattern);
+ return JS('JSExtendableArray', r'#.split(#)', this, pattern);
} else if (pattern is JSSyntaxRegExp) {
var re = regExpGetNative(pattern);
- return JS('=List', r'#.split(#)', this, re);
+ return JS('JSExtendableArray', r'#.split(#)', this, re);
} else {
throw "String.split(Pattern) UNIMPLEMENTED";
}
« sdk/lib/_internal/lib/js_rti.dart ('K') | « sdk/lib/_internal/lib/js_rti.dart ('k') | sdk/lib/_internal/lib/json_patch.dart » ('j') | sdk/lib/html/html_common/conversions.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698