Use smoke in polymer and polymer_expressions.

pkg/smoke/lib/mirrors.dart

Index: pkg/smoke/lib/mirrors.dart
diff --git a/pkg/smoke/lib/mirrors.dart b/pkg/smoke/lib/mirrors.dart
index ffd815d40cffbdd1a52fc23173b9407d2d1f7676..38ea40bce1048b5f7ca5bbf798b685e8124256ed 100644
--- a/pkg/smoke/lib/mirrors.dart
+++ b/pkg/smoke/lib/mirrors.dart
@@ -297,15 +297,17 @@ class _MethodClosure extends Function {
 
   _MethodClosure(this.receiver, this.methodName);
 
-  // We shouldn't need to include [call] here, but we do to work around an
-  // analyzer bug (see dartbug.com/16078). Interestingly, if [call] is invoked
-  // with the wrong number of arguments, then noSuchMethod is anyways invoked
-  // instead.
-  call() => invoke(receiver, methodName, const []);
-
-  noSuchMethod(Invocation inv) {
-    if (inv.memberName != #call) return null;
-    return invoke(receiver, methodName,
-        inv.positionalArguments, namedArgs: inv.namedArguments);
-  }
+  // Technically we could just use noSuchMethod to implement [call], but we

[Siggi Cherem (dart-lang), 2014/02/24 23:12:43]

I did one last change here to remove the use of nSM. It's technically not
correct to remove it, but (a) we don't use this in practice, and (b) it saves
space in the dart2js output (~25% on medium tests). I'm ok with doing so because
this is anyways a workaround for dartbug.com/13002.

I updated the comment here to clarify.

+  // don't for 3 reasons:
+  //   * noSuchMethod makes the code a lot bigger.
+  //   * even with noSuchMethod, an analyzer bug requires to declare [call] (see
+  //     dartbug.com/16078).
+  //   * having [call] also allows `is` checks to work for functions of 0
+  //     through 3 arguments.  We depend on this in
+  //     `polymer_expressions/lib/eval.dart` to check whether a function is a
+  //     filter (takes a single argument). (Note that it's possible to include
+  //     both [call] and [noSuchMethod], which would make instance-of checks
+  //     work with the signature of [call], but will allow invoking the function
+  //     using [noSuchMethod].
+  call([a, b, c]) => invoke(receiver, methodName, [a, b, c], adjust: true);
 }