Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1232)

Issue 1729973002: Reland of Add increment install native libraries first in lookup paths (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org, newt (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Add increment install native libraries first in lookup paths This fixes a subtle bug where the wrong libchromium_android_linker.so is used when it already exists in the system library path. BUG=587584 Committed: https://crrev.com/49451f675a97ee4704fa0dcf7a9acf054514dbaa Cr-Commit-Position: refs/heads/master@{#377290}

Patch Set 1 #

Patch Set 2 : fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java View 1 3 chunks +7 lines, -7 lines 0 comments Download
M build/android/incremental_install/java/org/chromium/incrementalinstall/Reflect.java View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (6 generated)
agrieve
Created Reland of Add increment install native libraries first in lookup paths
4 years, 10 months ago (2016-02-24 01:22:55 UTC) #1
agrieve
On 2016/02/24 01:22:55, agrieve wrote: > Created Reland of Add increment install native libraries first ...
4 years, 10 months ago (2016-02-24 01:47:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729973002/40001
4 years, 10 months ago (2016-02-24 01:50:21 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 02:49:39 UTC) #7
Xi Han
lgtm
4 years, 10 months ago (2016-02-24 14:28:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729973002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729973002/40001
4 years, 10 months ago (2016-02-24 14:30:49 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 10 months ago (2016-02-24 14:38:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 14:39:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/49451f675a97ee4704fa0dcf7a9acf054514dbaa
Cr-Commit-Position: refs/heads/master@{#377290}

Powered by Google App Engine
This is Rietveld 408576698