Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Unified Diff: third_party/WebKit/Source/platform/network/LinkHeader.h

Issue 1729963002: WIP/proof-of-concept to make blink::LinkHeader reuse net:: parsing code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@string-tokenizer-brackets
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/LinkHeader.h
diff --git a/third_party/WebKit/Source/core/loader/LinkHeader.h b/third_party/WebKit/Source/platform/network/LinkHeader.h
similarity index 79%
rename from third_party/WebKit/Source/core/loader/LinkHeader.h
rename to third_party/WebKit/Source/platform/network/LinkHeader.h
index 1e299ed6035e66414eb766598a495c6b9c7a2c03..380ad6ebb089c6086a53975e4ef4afd083b7aa72 100644
--- a/third_party/WebKit/Source/core/loader/LinkHeader.h
+++ b/third_party/WebKit/Source/platform/network/LinkHeader.h
@@ -5,23 +5,23 @@
#ifndef LinkHeader_h
#define LinkHeader_h
-#include "core/CoreExport.h"
-#include "core/html/CrossOriginAttribute.h"
+#include "platform/PlatformExport.h"
#include "wtf/Allocator.h"
#include "wtf/text/WTFString.h"
+#include <string>
+
namespace blink {
class LinkHeader {
DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
public:
- template <typename CharType>
- LinkHeader(CharType*& position, CharType* end);
+ LinkHeader(std::string::const_iterator begin, std::string::const_iterator end);
const String& url() const { return m_url; }
const String& rel() const { return m_rel; }
const String& as() const { return m_as; }
- CrossOriginAttributeValue crossOrigin() const { return m_crossOrigin; }
+ const String& crossOrigin() const { return m_crossOrigin; }
bool valid() const { return m_isValid; }
enum LinkParameterName {
@@ -44,11 +44,11 @@ private:
String m_url;
String m_rel;
String m_as;
- CrossOriginAttributeValue m_crossOrigin;
+ String m_crossOrigin;
bool m_isValid;
};
-class CORE_EXPORT LinkHeaderSet {
+class PLATFORM_EXPORT LinkHeaderSet {
STACK_ALLOCATED();
public:
LinkHeaderSet(const String& header);
@@ -59,9 +59,6 @@ public:
size_t size() { return m_headerSet.size(); }
private:
- template <typename CharType>
- void init(CharType* headerValue, unsigned len);
-
Vector<LinkHeader> m_headerSet;
};
« no previous file with comments | « third_party/WebKit/Source/platform/network/DEPS ('k') | third_party/WebKit/Source/platform/network/LinkHeader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698