Issue 1729933002: simplify generation of functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1729933002: simplify generation of functions (Closed)

Created:
4 years, 10 months ago by Jennifer Messerly

Modified:
4 years, 10 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

simplify generation of functions fixes incorrect destructuring codegen, and encapsulates type parameter comments better in _emitFunctionBody R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/881f4b9cbdd98c5e85c65a2a4499dd782226d111

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -135 lines)			Patch
	M	lib/src/codegen/js_codegen.dart	View		13 chunks	+110 lines, -131 lines	0 comments	Download
	M	test/codegen/expect/destructuring.js	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

Jennifer Messerly

(This refactoring is a step towards generic functions/methods. Trying to simplify functions before we add ...

4 years, 10 months ago (2016-02-24 00:36:08 UTC) #3

Jennifer Messerly

4 years, 10 months ago (2016-02-24 17:18:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
881f4b9cbdd98c5e85c65a2a4499dd782226d111 (presubmit successful).