Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 172993002: Removed O(n!) traversal of selectors for selectorList. (Closed)

Created:
6 years, 10 months ago by rune
Modified:
6 years, 10 months ago
Reviewers:
chrishtr, esprehn
CC:
blink-reviews, dglazkov+blink, rune+blink, apavlov+blink_chromium.org, ed+blinkwatch_opera.com, darktears
Visibility:
Public.

Description

Removed O(n!) traversal of selectors for selectorList. When collectFeaturesFromSelector got a for-loop for tagHistory in [1], the for-loop for tagHistory was kept in collectFeaturesFromSelectorList which means we did n! visits of n sub-selectors in selectors like :-webkit-any(.a.b.c). [1] https://codereview.chromium.org/143653010 R=esprehn,chrishtr BUG=335247 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167475

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M Source/core/css/RuleFeature.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
6 years, 10 months ago (2014-02-19 21:38:13 UTC) #1
esprehn
Woah, lgtm. n! eh?
6 years, 10 months ago (2014-02-19 21:41:44 UTC) #2
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 10 months ago (2014-02-19 21:41:47 UTC) #3
rune
On 2014/02/19 21:41:44, esprehn wrote: > Woah, lgtm. n! eh? n tends to be very ...
6 years, 10 months ago (2014-02-19 21:46:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/172993002/1
6 years, 10 months ago (2014-02-19 22:05:30 UTC) #5
chrishtr
lgtm
6 years, 10 months ago (2014-02-19 22:44:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/172993002/1
6 years, 10 months ago (2014-02-19 23:10:41 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 07:40:58 UTC) #8
Message was sent while issue was closed.
Change committed as 167475

Powered by Google App Engine
This is Rietveld 408576698