core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp - Issue 1729823004: refactor CPDF_Font and subclasses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

Issue 1729823004: refactor CPDF_Font and subclasses (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

diff --git a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

index 756e08646ab4bf25dbd2598d5bd90d5fd1b6d52f..85b026f8e85aa3039830d303417a2b7431b41ac8 100644

--- a/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

+++ b/core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp

@@ -261,12 +261,12 @@ CPDF_Font* CPDF_DocPageData::GetStandardFont(const CFX_ByteStringC& fontName,

continue;

if (pFont->IsEmbedded())

continue;

- if (pFont->GetFontType() != PDFFONT_TYPE1)

+ if (!pFont->IsType1Font())

continue;

if (pFont->GetFontDict()->KeyExist("Widths"))

continue;

- CPDF_Type1Font* pT1Font = pFont->GetType1Font();

+ CPDF_Type1Font* pT1Font = pFont->AsType1Font();

if (pEncoding && !pT1Font->GetEncoding()->IsIdentical(pEncoding))

continue;