runtime/observatory/tests/service/test_helper.dart - Issue 1729813002: Some dart2js fixes with new IDL. RequestCallback name and web_sql import

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1729813002: Some dart2js fixes with new IDL. RequestCallback name and web_sql import (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index 00978cafa169b7784cfd7ae76f5b98408a7e6747..91cb11eb37a531882917510dd1712593e3b5dfa2 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -28,8 +28,8 @@ bool _isTestee() {

}

class _SerivceTesteeRunner {

- Future run({Future testeeBefore(): null,

- Future testeeConcurrent(): null,

+ Future run({testeeBefore(): null,

Jacob 2016/02/24 00:18:20 why is this change in this CL?

Alan Knight 2016/02/24 00:24:58 Oops. Not synced properly. Fixed.

+ testeeConcurrent(): null,

bool pause_on_start: false,

bool pause_on_exit: false}) async {

if (!pause_on_start) {

« no previous file with comments | « no previous file | tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate » ('j') | no next file with comments »