Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1729813002: Some dart2js fixes with new IDL. RequestCallback name and web_sql import (Closed)

Created:
4 years, 10 months ago by Alan Knight
Modified:
4 years, 10 months ago
Reviewers:
terry, Jacob
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Some dart2js fixes with new IDL. RequestCallback name and web_sql import BUG= R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/ce744f6222b396b73ef7e733c19a095a9c493b5c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Merged #

Patch Set 3 : Merged again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +2 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alan Knight
4 years, 10 months ago (2016-02-23 23:09:40 UTC) #2
Jacob
lgtm assuming observatory file is removed https://codereview.chromium.org/1729813002/diff/1/runtime/observatory/tests/service/test_helper.dart File runtime/observatory/tests/service/test_helper.dart (right): https://codereview.chromium.org/1729813002/diff/1/runtime/observatory/tests/service/test_helper.dart#newcode31 runtime/observatory/tests/service/test_helper.dart:31: Future run({testeeBefore(): null, ...
4 years, 10 months ago (2016-02-24 00:18:20 UTC) #3
Alan Knight
https://codereview.chromium.org/1729813002/diff/1/runtime/observatory/tests/service/test_helper.dart File runtime/observatory/tests/service/test_helper.dart (right): https://codereview.chromium.org/1729813002/diff/1/runtime/observatory/tests/service/test_helper.dart#newcode31 runtime/observatory/tests/service/test_helper.dart:31: Future run({testeeBefore(): null, On 2016/02/24 00:18:20, Jacob wrote: > ...
4 years, 10 months ago (2016-02-24 00:24:58 UTC) #4
Alan Knight
4 years, 10 months ago (2016-02-24 00:28:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ce744f6222b396b73ef7e733c19a095a9c493b5c.

Powered by Google App Engine
This is Rietveld 408576698