Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4238)

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 17298002: Allow tabCapture API to be granted for chrome:// pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix permissions tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_keybinding_apitest.cc
diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc
index 07906a18b79c18956c16bb9ed74de4674f3dd134..2a3c8268a3a98537f03a4420e77c263974233fc0 100644
--- a/chrome/browser/extensions/extension_keybinding_apitest.cc
+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc
@@ -73,16 +73,14 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest, Basic) {
WebContents* tab = browser()->tab_strip_model()->GetActiveWebContents();
ASSERT_TRUE(tab);
- ActiveTabPermissionGranter* granter =
- TabHelper::FromWebContents(tab)->active_tab_permission_granter();
- EXPECT_FALSE(granter->IsGranted(extension));
+ EXPECT_FALSE(ActiveTabPermissionGranter::IsGrantedForTab(extension, tab));
// Activate the shortcut (Ctrl+Shift+F).
ASSERT_TRUE(ui_test_utils::SendKeyPressSync(
browser(), ui::VKEY_F, true, true, false, false));
// activeTab should now be granted.
- EXPECT_TRUE(granter->IsGranted(extension));
+ EXPECT_TRUE(ActiveTabPermissionGranter::IsGrantedForTab(extension, tab));
// Verify the command worked.
bool result = false;

Powered by Google App Engine
This is Rietveld 408576698