Allow tabCapture API to be granted for chrome:// pages.

chrome/browser/extensions/active_tab_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/values.h"
@@ skipping 21 matching lines @@
 using base::DictionaryValue;
 using base::ListValue;
 using content::BrowserThread;
 using content::NavigationController;
 
 namespace extensions {
 namespace {
 
 scoped_refptr<const Extension> CreateTestExtension(
     const std::string& id,
-    bool has_active_tab_permission) {
+    bool has_active_tab_permission,
+    bool has_tab_capture_permission) {
   ListBuilder permissions;
   if (has_active_tab_permission)
     permissions.Append("activeTab");
+  if (has_tab_capture_permission)
+    permissions.Append("tabCapture");
   return ExtensionBuilder()
       .SetManifest(DictionaryBuilder()
           .Set("name", "Extension with ID " + id)
           .Set("version", "1.0")
           .Set("manifest_version", 2)
           .Set("permissions", permissions))
       .SetID(id)
       .Build();
 }
 
 class ActiveTabTest : public ChromeRenderViewHostTestHarness {
  protected:
   ActiveTabTest()
-      : extension(CreateTestExtension("deadbeef", true)),
-        another_extension(CreateTestExtension("feedbeef", true)),
-        extension_without_active_tab(CreateTestExtension("badbeef", false)) {}
+      : extension(CreateTestExtension("deadbeef", true, false)),
+        another_extension(CreateTestExtension("feedbeef", true, false)),
+        extension_without_active_tab(CreateTestExtension("badbeef",
+                                                         false,
+                                                         false)),
+        extension_with_tab_capture(CreateTestExtension("cafebeef",
+                                                       true,
+                                                       true)) {}
 
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
     TabHelper::CreateForWebContents(web_contents());
   }
 
   int tab_id() {
     return SessionID::IdForTab(web_contents());
   }
 
@@ skipping 43 matching lines @@
   }
 
   // An extension with the activeTab permission.
   scoped_refptr<const Extension> extension;
 
   // Another extension with activeTab (for good measure).
   scoped_refptr<const Extension> another_extension;
 
   // An extension without the activeTab permission.
   scoped_refptr<const Extension> extension_without_active_tab;
+
+  // An extension with both the activeTab and tabCapture permission.
+  scoped_refptr<const Extension> extension_with_tab_capture;
 };
 
 TEST_F(ActiveTabTest, GrantToSinglePage) {
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   // No access unless it's been granted.
   EXPECT_TRUE(IsBlocked(extension, google));
   EXPECT_TRUE(IsBlocked(another_extension, google));
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, google));
@@ skipping 99 matching lines @@
   EXPECT_TRUE(IsBlocked(extension_without_active_tab, chromium));
 };
 
 TEST_F(ActiveTabTest, Uninstalling) {
   // Some semi-arbitrary setup.
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
-  EXPECT_TRUE(active_tab_permission_granter()->IsGranted(extension.get()));
+  EXPECT_TRUE(ActiveTabPermissionGranter::IsGrantedForTab(extension.get(),
+                                                          web_contents()));
   EXPECT_TRUE(IsAllowed(extension, google));
 
   // Uninstalling the extension should clear its tab permissions.
   UnloadedExtensionInfo details(extension.get(),
                                 extension_misc::UNLOAD_REASON_DISABLE);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_UNLOADED,
       content::Source<Profile>(Profile::FromBrowserContext(
           web_contents()->GetBrowserContext())),
       content::Details<UnloadedExtensionInfo>(&details));
 
-  EXPECT_FALSE(active_tab_permission_granter()->IsGranted(extension.get()));
   // Note: can't EXPECT_FALSE(IsAllowed) here because uninstalled extensions
   // are just that... considered to be uninstalled, and the manager might
   // just ignore them from here on.
 
   // Granting the extension again should give them back.
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
-  EXPECT_TRUE(active_tab_permission_granter()->IsGranted(extension.get()));
+  EXPECT_TRUE(ActiveTabPermissionGranter::IsGrantedForTab(extension.get(),
+                                                          web_contents()));
   EXPECT_TRUE(IsAllowed(extension, google));
 }
 
 TEST_F(ActiveTabTest, OnlyActiveTab) {
   GURL google("http://www.google.com");
   NavigateAndCommit(google);
 
   active_tab_permission_granter()->GrantIfRequested(extension.get());
 
   EXPECT_TRUE(IsAllowed(extension, google, tab_id()));
@@ skipping 37 matching lines @@
   EXPECT_TRUE(IsAllowed(extension, chromium_h1, tab_id()));
 
   Reload();
 
   EXPECT_FALSE(IsAllowed(extension, google, tab_id()));
   EXPECT_FALSE(IsAllowed(extension, google_h1, tab_id()));
   EXPECT_FALSE(IsAllowed(extension, chromium, tab_id()));
   EXPECT_FALSE(IsAllowed(extension, chromium_h1, tab_id()));
 }
 
+// TODO(justinlin): Enable when tabCapture API is moved to stable.

[not at google - send to devlin, 2013/09/13 22:09:45]

could you use ScopedCurrentChannel in feature_channel.h and enable it now?

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

[justinlin, 2013/09/13 22:47:15]

Done.

+TEST_F(ActiveTabTest, DISABLED_ChromeUrlGrants) {
+  GURL internal("chrome://version");
+  NavigateAndCommit(internal);
+  active_tab_permission_granter()->GrantIfRequested(
+      extension_with_tab_capture.get());
+  // Do not grant tabs/hosts permissions for tab.
+  EXPECT_TRUE(IsBlocked(extension_with_tab_capture, internal, tab_id()));
+  EXPECT_TRUE(PermissionsData::HasAPIPermissionForTab(
+      extension_with_tab_capture.get(),
+      tab_id(),
+      APIPermission::kTabCaptureForTab));
+
+  EXPECT_TRUE(IsBlocked(extension_with_tab_capture, internal, tab_id() + 1));
+  EXPECT_FALSE(PermissionsData::HasAPIPermissionForTab(
+      extension_with_tab_capture.get(),
+      tab_id() + 1,
+      APIPermission::kTabCaptureForTab));
+}
+
 }  // namespace
 }  // namespace extensions