Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1729783002: Don't clip FFT output values to minDecibels. (Closed)

Created:
4 years, 10 months ago by Raymond Toy
Modified:
4 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, kinuko+watch, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't clip FFT output values to minDecibels. If the (linear) FFT value is zero, the dB value was set to analyser.minDecibels. The spec doesn't require this and it makes more sense to return the expected -Infinity instead. BUG=588853 TEST=realtimeanalyser-zero.html Committed: https://crrev.com/ef6f6ae5e4c96622286b563658d5cd62a6cf1197 Cr-Commit-Position: refs/heads/master@{#378081}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-zero.html View 1 chunk +63 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/webaudio/realtimeanalyser-zero-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp View 3 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/audio/AudioUtilities.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Raymond Toy
PTAL
4 years, 10 months ago (2016-02-24 19:28:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729783002/1
4 years, 10 months ago (2016-02-25 22:44:47 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/27692)
4 years, 10 months ago (2016-02-25 23:28:46 UTC) #6
hongchan
lgtm
4 years, 10 months ago (2016-02-26 22:33:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729783002/1
4 years, 10 months ago (2016-02-26 22:40:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-27 02:11:25 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-27 02:13:02 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef6f6ae5e4c96622286b563658d5cd62a6cf1197
Cr-Commit-Position: refs/heads/master@{#378081}

Powered by Google App Engine
This is Rietveld 408576698